Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate initializer functions in the Res file to avoid the MethodTooLargeException #4205

Merged
merged 2 commits into from Jan 31, 2024
Merged

Generate initializer functions in the Res file to avoid the MethodTooLargeException #4205

merged 2 commits into from Jan 31, 2024

Conversation

terrakok
Copy link
Collaborator

No description provided.

@terrakok terrakok requested a review from pjBooms January 30, 2024 15:50
@terrakok terrakok mentioned this pull request Jan 30, 2024
Closed
@terrakok terrakok force-pushed the k.tskh/res-gen-fix branch 2 times, most recently from 81b5eb2 to cc5b8b0 Compare January 31, 2024 09:36
MatkovIvan
MatkovIvan reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a reproduction of MethodTooLargeException case to test-projects?

@terrakok
Copy link
Collaborator Author

Should we add a reproduction of MethodTooLargeException case to test-projects?

done

@terrakok terrakok merged commit b1e86ad into master Jan 31, 2024
6 checks passed
@terrakok terrakok deleted the k.tskh/res-gen-fix branch January 31, 2024 11:41
@ChristianKatzmann ChristianKatzmann mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjBooms pjBooms pjBooms approved these changes

@MatkovIvan MatkovIvan Awaiting requested review from MatkovIvan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terrakok @MatkovIvan @pjBooms