Make desktop preview task fully configuration cache compliant

[eygraber]

Issues fixed

1. Set org.gradle.configuration-cache=true in ~/.gradle/gradle.properties
2. Install Compose Multiplatform IDE Support IDEA plugin
3. Open the project gradle-plugins/compose/src/test/test-projects/misc/jvmPreview
4. Change build.gradle to:

subprojects {
    repositories {
        mavenLocal()
        google()
        gradlePluginPortal()
        maven {
            url 'https://maven.pkg.jetbrains.space/public/p/compose/dev'
        }
    }
}

5. change settings.gradle to:

pluginManagement {
    plugins {
        id 'org.jetbrains.kotlin.multiplatform' version '1.9.22'
        id 'org.jetbrains.kotlin.jvm' version '1.9.22'
        id 'org.jetbrains.compose' version '1.6.0'
    }
    repositories {
        mavenLocal()
        gradlePluginPortal()
        maven {
            url 'https://maven.pkg.jetbrains.space/public/p/compose/dev'
        }
    }
}
rootProject.name = 'jvmPreview'
include(':common', ':jvm', ':mpp')

6. Sync the project.

7. Go to common/src/commonMain/kotlin/preview.kt. Open the preview.

8. See the crash:

Configuration cache problems found in this build.

1 problem was found storing the configuration cache.
- Task `:common:configureDesktopPreviewDesktop` of type `org.jetbrains.compose.desktop.preview.tasks.AbstractConfigureDesktopPreviewTask`: invocation of 'Task.project' at execution time is unsupported.
  See https://docs.gradle.org/8.4/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution

Proposed changes

The issue was in a case where there wasn't a direct dependency on the skiko artifact, the task would attempt to get one at task execution time. This moves that to task configuration time.

Testing

• The issue no longer reproduced.
• The new test passes

This should be tested by QA.

[eygraber]

@igordmn any idea on when this could get looked at?

[igordmn]

Thanks! Lgtm.

I changed the description to comply our new guidelines that aren't enforced yet. Does it look okay?

[eygraber]

Description looks ok. Do you want to add that an integration test was added, or is that section only for manual QA testing?

[igordmn]

Do you want to add that an integration test was added, or is that section only for manual QA testing?

Thanks, added. This is for all kinds of testing.