Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the experimental mark from the stable resources library API #4623

Merged
merged 2 commits into from Apr 18, 2024

Conversation

terrakok
Copy link
Collaborator

@terrakok terrakok commented Apr 16, 2024

And remove internal testing methods

Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Needs a second review before the merge.

@@ -14,7 +14,6 @@ annotation class InternalResourceApi
* @property id The ID of the resource.
* @property items The set of resource items associated with the resource.
*/
@ExperimentalResourceApi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but because we are removing experimental, we have to support API backward compatibility, and better to apply https://github.com/Kotlin/binary-compatibility-validator plugin for that

@terrakok terrakok merged commit 2d225f3 into master Apr 18, 2024
3 of 12 checks passed
@terrakok terrakok deleted the k.tskh/stable-api branch April 18, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants