Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete outdated build services #4959

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

terrakok
Copy link
Collaborator

We had two build services:

  1. to check unsupported compose compiler plugins were applied
  2. to check a native cache kind configuration

Both of them are outdated and we may get rid of them.

Fixes #4815

Release Notes

Fixes - Gradle Plugin

  • Delete outdated build services

@terrakok terrakok requested review from igordmn and eymar June 12, 2024 14:00
Copy link
Collaborator

@eymar eymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed it today. Here is why I think these changes are okay:

  • checking for 3rd party compiler plugin is not needed anymore, since we already have one compiler plugin for all platforms in Kotlin 2. The check might be still relevant for projects with kotlin < 2.0, but given that Build Service causes issues in some cases, the check can be dropped now, without waiting for full kotlin 2.0 adoption
  • check for native caches flags. We used to force all users to disable caches to make Compose work (before kotlin 1.9.0 or even earlier versions). Then when k/native implemented certain fixes, the caches started to work, and we wanted the users to drop their settings where they disabled the caches. Now, most projects probably dropped it. And the check is not relevant anymore.

@terrakok terrakok merged commit a73ed61 into master Jun 13, 2024
12 checks passed
@terrakok terrakok deleted the k.tskh/delete-build-services branch June 13, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encountered error after upgrading from 1.6.10-beta01 to 1.6.10-rc01
3 participants