-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger local symbol provider #8
Merged
auduchinok
merged 13 commits into
JetBrains:wave12
from
vasily-kirichenko:debugger-local-symbol-provider
May 8, 2018
Merged
Debugger local symbol provider #8
auduchinok
merged 13 commits into
JetBrains:wave12
from
vasily-kirichenko:debugger-local-symbol-provider
May 8, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vasily-kirichenko
commented
Apr 4, 2018
•
edited
Loading
edited
uncomment WPF code
vasily-kirichenko
force-pushed
the
debugger-local-symbol-provider
branch
from
May 8, 2018 13:56
6ca9fb3
to
7e63907
Compare
I've rebased on master and removed the unneeded code as you updated FCS. |
…into debugger-local-symbol-provider
auduchinok
approved these changes
May 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is awesome, thank you Vasily! |
auduchinok
pushed a commit
that referenced
this pull request
May 8, 2018
* add FSharpDebuggerLocalSymbolProvider * wip * works for let or use * proper `pos` * it works for let/use and args * fix node find uncomment WPF code * handle ForEach * remove not needed code after upgrading FCS * fix a typo in naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.