VIM-1357+VIM-1566: Use OS shell to run filter command #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling Also moves the filter command out of a write action, and under a cancellable modal progress dialog. Any errors are substituted into the text, as per Vim. Fixes #VIM-1357
citizenmatt
changed the title
citizenmatt
changed the title
|
That's great! Thank you for the fixes! |
|
thanks for this PR, really love my shell filters in Vim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few issues with the filter (
:!) command:$SHELLorsh, on Windows, this iscmd.exe. Fixes VIM-1566 and VIM-1357'shellcmdflag','shellxescape'and'shellxquote'options, required to properly run, quote and escape parameters%inside a filter command, mapping to the current file name