VIM-1062 #333
Merged
VIM-1062 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexPl292
requested changes
Jun 25, 2021
| override val argFlags = flags(RangeFlag.RANGE_OPTIONAL, ArgumentFlag.ARGUMENT_OPTIONAL, Access.READ_ONLY) | ||
| override fun execute(editor: Editor, context: DataContext, cmd: ExCommand): Boolean { | ||
| val arg = cmd.argument.trim() | ||
| if (arg.isNotEmpty() && arg.matches(Regex("^\\d+$"))) { |
There was a problem hiding this comment.
You can use toIntOrNull instead of regex check
| final FileEditorManagerEx fileEditorManager = FileEditorManagerEx.getInstanceEx(project); | ||
| final EditorWindow window = fileEditorManager.getCurrentWindow(); | ||
| VirtualFile[] editors = fileEditorManager.getOpenFiles(); | ||
| if (number == 99) { |
There was a problem hiding this comment.
it was by mistake. i removed it.
| if (number >= 0 && number < editors.length) { | ||
| fileEditorManager.closeFile(editors[number], window); | ||
| } | ||
| if (number < 0 || number >= editors.length) { |
There was a problem hiding this comment.
it was by mistake. i removed it.
|
That's great, thank you for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/VIM-1062
added:
:bn select the next editor tab, circling from the last to the first
:bp select the previous editor tab, circling from the first to the last
:bd or bdX