Add Matchit support for PHP #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapOf happens to give us LinkedHashMaps, but we'll use the explicit constructor since insertion order matters for PatternsTables.
The less than/greater than operators are the only binary expressions in the JS patterns, so the extra PSI checks are redundant.
Providing a custom tagNamePattern makes it easier to interop with languages like PHP.
|
Looks great, no doubt this should be merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Matchit patterns required for PHP language support. PHP was requested in VIM-2678 and VIM-2937.
The unit test file is long since the language has a lot of patterns, but the motions themselves are straightforward. I made some small refactorings with notes in the earlier commits.