Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gx command #731

Closed
wants to merge 5 commits into from
Closed

gx command #731

wants to merge 5 commits into from

Conversation

leonspohr
Copy link

I have gone ahead and added the missing gx command.

Concerning issue:
https://youtrack.jetbrains.com/issue/VIM-1341/gx-should-open-selection-in-browser

@AlexPl292
Copy link
Member

Hi there! I see that there are 116 changed files and most of them contain formatting of them. Even if this might be a good thing to format the files, I wouldn't add such a huge change to the pull request. Could you please revert the formatting changes and leave only changes with the gx command?

@leonspohr
Copy link
Author

Well, I agree that those formatting shouldnt be included here. But those changes were not done by me, but by ideavim bot

AlexPl292 added a commit that referenced this pull request Oct 27, 2023
Because of some reason actions started on
#731
pull request and updated it.
With this change, forks won't be affected by forked actions. If the action is still needed on fork, these conditions can be changes
@AlexPl292
Copy link
Member

This is unexpected, as I understand, the actions should be explicitly enabled on forks. Anyway, to avoid such issues, I've added a condition for actions to work on JetBrains/ideavim repository.

Regarding the change: Unfortunatelly, with this change the gx command will not only open links, but also jump to the declarations or usages. This is undesired behavior, so it looks like we need some verification that we're working on the URL.

@leonspohr leonspohr marked this pull request as draft October 27, 2023 07:52
@leonspohr leonspohr closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants