Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matchit support for Java statements #802

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add Matchit support for Java statements #802

merged 1 commit into from
Feb 20, 2024

Conversation

chylex
Copy link
Contributor

@chylex chylex commented Jan 22, 2024

Adds matchit support for if/else, do/while, and try/catch/finally statements in Java.

@AlexPl292
Copy link
Member

Great, thank you!

@AlexPl292 AlexPl292 merged commit f478263 into JetBrains:master Feb 20, 2024
4 checks passed
AlexPl292 added a commit that referenced this pull request Feb 20, 2024
@AlexPl292
Add tests for new java matchit functionality
7d8973e 
From PR #802
@chylex
Copy link
Contributor Author

chylex commented Feb 23, 2024

FYI the new unit tests don't test jumping from try to catch to finally, might be worth testing too. I can add the test if you want, but for you it might be faster to just add it than deal with another PR.

AlexPl292 added a commit that referenced this pull request Feb 23, 2024
@AlexPl292
Add matchit test for jump from try to catch and to finally
10edccc 
From PR #802
@AlexPl292
Copy link
Member

Thank you, added this one as well

@chylex chylex deleted the pr-matchit-java branch March 22, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@chylex @AlexPl292