Bug fixes for IdeaVim and Code With Me #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always ignores non-local, hidden editors opened by remote guests in Code With Me sessions. Fixes VIM-3268
Fixes VIM-2167
Reviews all IntelliJ listeners to ensure that they only work with supported local editors. Editor creation was initialising IdeaVim for all editors, which meant that behaviour could leak into Code With Me guest editors. E.g. guest editors incorrectly drawing relative line numbers, or the host using the guest's last selected tab when switching to an alternate file. This leads to a change in behaviour with some local editors. The editor creation listener will now check to see if the editor is local *and supported*. This means it can exclude single line editors, editors in database cells or dialogs, depending on the state of 'ideavimsupport' at creation time. The behaviour at creation time is now more correct, but if 'ideavimsupport' is modified, existing matching editors will not be initialised. Fixes VIM-3274, fixes VIM-3275
This means we listen to changes in all documents, rather than just the changes in the documents for open local editors. And this means that we correctly update e.g. marks when a non-local editor changes a file that isn't open in a local editor.
IdeaVim actions are local only - they control local behaviour and should not be visible in the Client Fixes VIM-3283
citizenmatt
force-pushed
the
bugfix/cwm-fixes
branch
from
23d046f
to
ea85f55
Compare
|
Cool, merged! CWM should be happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of bugs in IdeaVim when being used in Code With Me scenarios, mainly when installed on the host, but also fixes issues when installed on both host and guest (JetBrains Client)
Primarily, it updates the API used to get the editors that are in use by the host, correctly ignoring the non-local, hidden editors used by remote guests, and ensures that any editor listeners are only working with local editors. It fixes the following issues:
<C-^>) on the host could switch to the last selected file on the guest (VIM-3274)There is a minor change in behaviour when a new editor is created. Previously, IdeaVim would incorrectly register listeners and initialise options, etc. for all windows. Now it only initialises editors that are supported by IdeaVim. This means local editors, but it's also dependent on the
'ideavimsupport'option to decide if it should handle single line editors or editors inside dialogs. Previously, because the listeners were always registered, changing the'ideavimsupport'option would allow these editors to immediately start working. Now, they are only possibly initialised at creation time. If the option is changed, the editor would need to be closed and reopened. I do not expect this option to be changed during an interactive session, so I believe this is reasonable.There are other issues outstanding for remote development scenarios, where IdeaVim is installed in the Client. This is currently blocked waiting a means to debug this scenario. I'll take a look when I get debugging working.