Add catch for potentially missing directories #2280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the IconsClassGenerator script for generating icons and one of the modules depends on a module that gets dynamically generated, the script will crash out, as it may not exist. Needed for Android. Change-Id: I0a2d9a0cbc26649bf429fef8329c6b0ab4de2131
|
@jrlogsdon, I believe the problem is not in this script, but in broken project structure. Please take a look at https://git.jetbrains.org/?p=idea/android.git;a=commitdiff;h=36d5d8a58e1a0ceb34c045c2619299f23478b7c7 Why do you have these directories in the first place? |
|
These will be removed when making the icon swap change, but there's still another module that relies on a Bazel generated module. |
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
In Android Studio some directories are generated dynamically by Bazel. These directories are referenced from iml files, but directories do not exist until Bazel is executed. Make sure that IconsClassGenerator can generate files in this edge case as well. In intellij we have tests for project structure which (among other things) check that iml files have no references to non-existing directories, so this exception never risen in intellij sources. #2280 Change-Id: I0a2d9a0cbc26649bf429fef8329c6b0ab4de2131 GitOrigin-RevId: 584c3b1d32b264dbe1e71a7b029a3eec084e9a41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the IconsClassGenerator script for generating icons and one of the modules depends on a module that gets dynamically generated, the script will crash out, as it may not exist. Needed for Android.
Change-Id: I0a2d9a0cbc26649bf429fef8329c6b0ab4de2131