Make SourceSearcher an extension point #2281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows third parties to contribute ways to retrieve sources for possibly non-standard JAR files.
|
@vladsoroka just wondering what's your opinion on this. If you think it's ok/something useful I'll rebase and solve conflicts. |
karollewandowski
force-pushed
the
master
branch
from
08f2151
to
d1f830e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows third parties to contribute ways to retrieve sources for possibly non-standard JAR files.
Building block for #2127
A question: can we delegate to
SourceSearchers the extraction ofgroupId,artifactId, andversion?This is currently done in
InternetAttachSourceProvider, but the logic used is not always correct.Usage example might be
P2SourceSearcher, which finds source JARs in p2 repositories.