New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IDEA-138776] Maven polyglot support #278
Conversation
Could you please remove .jps-build-data from your pull request? |
Seems like a nice first step! |
Have you submitted a contributor license agreement? If not, please download the PDF from http://www.jetbrains.org/display/IJOS/Contributor+Agreement and then print it out, sign (mention you github account name there), scan and email to contribute@jetbrains.com |
I just emailed the signed agreement |
CA received, thanks. |
You should probably remove some unwanted changes like changing the Java version to 7 or adding CoffeeScript to |
I started with master. Should I just remove these files? |
You should remove the changes in these files, not the files themselves. Note that these configuration files might have been changed not directly by you, but rather by IDEA which noticed changes in the Settings (e.g. if you modified the code style from the UI). |
Yeah I'm not sure what changed the files, but what I'm sure of is that you didn't look at what you were commiting when you did the commit :P |
Um, I looked at everything. But, I didn't know what was required. I'm not sure why the config files are in the repo. But, I'll remove the changes. |
+1 |
@Randgalt Could you possibly squash the 3 commits into one? That should help this get merged I would think, especially as a bunch of weird local config files were included in the first commit. If you need help with this let me know I can assist. |
@brcolow what would help me is to know what files I should not have committed. I can revert whatever needs reverting and then sqaush the commits. |
Could someone from JetBrains take a look at this as it is clearly a popular feature request and we'd love to see it added.Thank you 😸 ! |
+1 |
No worries - this was a strawman proposal anyway. |
Massive changes to support Maven Polyglot. I was flying blind with this. I hope I've done OK. Currently, only Groovy is supported but it will be easy to add others. Changes: