Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA-138776] Maven polyglot support #278

Closed
wants to merge 3 commits into from

Conversation

Randgalt
Copy link

Massive changes to support Maven Polyglot. I was flying blind with this. I hope I've done OK. Currently, only Groovy is supported but it will be easy to add others. Changes:

  • maven32-server-impl is removed
  • maven33-server-impl added
  • Polyglot type added to Maven settings panel
  • Everywhere "pom.xml" is referenced, polyglot methods are used instead
  • maven-polyglot-converter module added which converts on disk format to standard XML for internal use

@yole
Copy link
Contributor

yole commented Jun 23, 2015

Could you please remove .jps-build-data from your pull request?

@Randgalt Randgalt changed the title Maven polyglot [IDEA-138776] Maven polyglot support Jun 23, 2015
@Ribesg
Copy link

Ribesg commented Jun 24, 2015

Seems like a nice first step!
Can't wait for this!

@klikh
Copy link
Member

klikh commented Jun 25, 2015

Have you submitted a contributor license agreement? If not, please download the PDF from http://www.jetbrains.org/display/IJOS/Contributor+Agreement and then print it out, sign (mention you github account name there), scan and email to contribute@jetbrains.com

@Randgalt
Copy link
Author

I just emailed the signed agreement

@klikh
Copy link
Member

klikh commented Jun 25, 2015

CA received, thanks.

@Ribesg
Copy link

Ribesg commented Jun 29, 2015

You should probably remove some unwanted changes like changing the Java version to 7 or adding CoffeeScript to .idea/codeStyleSettings.xml.

@Randgalt
Copy link
Author

You should probably remove some unwanted changes like
changing the Java version to 7 or adding CoffeeScript to .idea/codeStyleSettings.xml.

I started with master. Should I just remove these files?

@klikh
Copy link
Member

klikh commented Jun 30, 2015

I started with master. Should I just remove these files?

You should remove the changes in these files, not the files themselves.

Note that these configuration files might have been changed not directly by you, but rather by IDEA which noticed changes in the Settings (e.g. if you modified the code style from the UI).

@Ribesg
Copy link

Ribesg commented Jun 30, 2015

Yeah I'm not sure what changed the files, but what I'm sure of is that you didn't look at what you were commiting when you did the commit :P

@Randgalt
Copy link
Author

Um, I looked at everything. But, I didn't know what was required. I'm not sure why the config files are in the repo. But, I'll remove the changes.

@cemo
Copy link

cemo commented Jul 3, 2015

+1

@brcolow
Copy link

brcolow commented Jul 12, 2015

@Randgalt Could you possibly squash the 3 commits into one? That should help this get merged I would think, especially as a bunch of weird local config files were included in the first commit. If you need help with this let me know I can assist.

@Randgalt
Copy link
Author

@brcolow what would help me is to know what files I should not have committed. I can revert whatever needs reverting and then sqaush the commits.

@neilellis
Copy link

Could someone from JetBrains take a look at this as it is clearly a popular feature request and we'd love to see it added.Thank you 😸 !

@vasilievip
Copy link

+1

@vladsoroka
Copy link
Contributor

Thanks for the contribution, however we can not merge this PR, since the feature was implemented slightly different.
You can try the feature using the nearest EAP (IDEA 2016.3 EAP build >= #163.4830.3).
Your feedback are welcome!

You can find the change at a2c139b

@Randgalt
Copy link
Author

No worries - this was a strawman proposal anyway.

@Randgalt Randgalt closed this Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants