Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pyb.pyi. #116

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Create pyb.pyi. #116

merged 1 commit into from
Sep 21, 2020

Conversation

hlovatt
Copy link
Contributor

@hlovatt hlovatt commented Jul 25, 2020

@hlovatt hlovatt changed the title Create pyb.pyi Create pyb.pyi. Aug 30, 2020
@vlasovskikh vlasovskikh self-assigned this Sep 20, 2020
@vlasovskikh vlasovskikh added this to In progress in 1.1.2 via automation Sep 20, 2020
@vlasovskikh vlasovskikh moved this from In progress to To do in 1.1.2 Sep 20, 2020
@vlasovskikh vlasovskikh removed their assignment Sep 20, 2020
Copy link
Contributor

@vlasovskikh vlasovskikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hlovatt This stub file looks very impressive! Thank you for contributing it! I like how you added docs from the corresponding *.rst via your rst2pyi.py. Is pyb.py in your Generator project something that you've created manually or automatically?

Your stub covers lots of things. I haven't checked all the methods and I just looked at the general style of your definitions and how it reflected the structure of the pyb docs. If there are any missing methods or bugs in type hints, I'm sure future pull requests by contributors will make things more correct eventually :)

@vlasovskikh vlasovskikh merged commit dddbaed into JetBrains:master Sep 21, 2020
1.1.2 automation moved this from To do to Done Sep 21, 2020
@vlasovskikh
Copy link
Contributor

@hlovatt You might be interested in how I added pyb to be available for code insight if your device type is "Pyboard" in the MicroPython settings in PyCharm: see the corresponding commit 138fcee. It's really a one-line change.

@hlovatt
Copy link
Contributor Author

hlovatt commented Sep 21, 2020 via email

@vlasovskikh
Copy link
Contributor

This PR fixes most of the issues mentioned #16.

@vlasovskikh
Copy link
Contributor

Thanks. Unfortunately I had to write pyb.py manually :( -- Howard.

Ouch... That's a huge amount of work. Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
1.1.2
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants