Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 232 and fix REPL #253

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Conversation

lancelote
Copy link
Member

No description provided.

Switch from the deprecated `TerminalProcessOptions` to
`ShellStartupOptions` new API
@PierreDeQuebec
Copy link
Contributor

Hi lancelote,
Thank you for your work. I inserted the changes in my copy of the plugins and kept my changes on the list of USB identifiers in the Esp8266DeviceProvider class and recompiled the plugins. And it works!

I added the Adafruit ID (0x239A, 0x8038).

  override val usbIds: List<MicroPythonUsbId>
    get() = listOf(MicroPythonUsbId(0x1A86, 0x7523),
                   MicroPythonUsbId(0x10C4, 0xEA60),
                   MicroPythonUsbId(0x0403, 0x6001),
                   MicroPythonUsbId(0x239A, 0x8038))

@lancelote
Copy link
Member Author

@PierreDeQuebec Thank you for taking a look at the changes 🙏 Would you like to open a pull request to add Metro M4 Airlift Lite support?

@PierreDeQuebec
Copy link
Contributor

GitHub rejects my pull request because I am not a contributor. Not being a Git Jedi, I can't tell if I'm doing a pull request the wrong way.

@lancelote
Copy link
Member Author

@PierreDeQuebec That's weird. Anyway, I created a PR on your behalf, I hope you don't mind - #254.

@Elizaveta239
Copy link
Contributor

Hi @lancelote! Thank you very much for your fix! :)

@jesen2010
Copy link

jesen2010 commented Nov 21, 2023

Hi,pycharm-community-2023.2.4 REPL with the newest plug updated Oct 12 still can not work. Tested on Pico board and a esp32c3 board got the same result,but REPL in pycharm-community-2023.1.4 is working correctly.

@lancelote
Copy link
Member Author

Hi @jesen2010, which OS do you use?

@jesen2010
Copy link

Hi @jesen2010, which OS do you use?

Hi,lancelote,thanks for your quick reply,My OS:win10----Windows Feature Experience Pack 1000.19052.1000.0 My laptop's cpu is AMD Ryzen 9 5900HX with Radeon Graphics ,Can it be caused by the cpu? I will try today with another laptop with intel cpu

@jesen2010
Copy link

Hi @jesen2010, which OS do you use?

Hi lancelote,I did a test on another laptop with Intel CPU,REPL still can not work.

@lancelote
Copy link
Member Author

lancelote commented Nov 23, 2023

It is OS-dependant. Should be fixed by #264, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants