Skip to content

Commit

Permalink
Support runIde.jbrVersion in 17.0.4.1-b653.1 format #1172
Browse files Browse the repository at this point in the history
  • Loading branch information
hsz committed Oct 28, 2022
1 parent 1edc6dd commit 5f618d9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
- Replace internal Gradle ConventionTask with DefaultTask [#1115](../../issues/1115) by @aSemy
- Plugin Verifier cache directory now follows XDG cache standards [#1119](../../issues/1119) by @aSemy
- Migrate most of the Gradle API in `IntelliJPlugin.kt` to use the Gradle Kotlin DSL extensions [#1117](../../issues/1117) by @aSemy
- Support `runIde.jbrVersion` in `17.0.4.1-b653.1` format [#1172](../../issues/1172)

### Changed
- Set minimum supported Gradle version from `6.7.1` to `6.8`
Expand Down
6 changes: 5 additions & 1 deletion src/main/kotlin/org/jetbrains/intellij/jbr/JbrResolver.kt
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,7 @@ abstract class JbrResolver @Inject constructor(
false -> version.substring(lastIndexOfDash)
}
val buildNumberString = when (lastIndexOfB > -1) {
lastIndexOfDash == lastIndexOfB -> version.substring(0, lastIndexOfDash - 1)
true -> version.substring(lastIndexOfB + 1)
else -> ""
}
Expand Down Expand Up @@ -244,7 +245,10 @@ abstract class JbrResolver @Inject constructor(
}

private fun getPrefix(version: String, variant: String?) = when {
!variant.isNullOrEmpty() -> "jbr_$variant-"
!variant.isNullOrEmpty() -> when(variant) {
"sdk" -> "jbrsdk-"
else -> "jbr_$variant-"
}
version.startsWith("jbrsdk-") -> "jbrsdk-"
version.startsWith("jbr_jcef-") -> "jbr_jcef-"
version.startsWith("jbr_dcevm-") -> "jbr_dcevm-"
Expand Down

0 comments on commit 5f618d9

Please sign in to comment.