Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong IDE platform prefix #1525

Closed
Undin opened this issue Jan 11, 2024 · 1 comment
Closed

Wrong IDE platform prefix #1525

Undin opened this issue Jan 11, 2024 · 1 comment
Labels
Milestone

Comments

@Undin
Copy link
Contributor

Undin commented Jan 11, 2024

What happened?

Starting with 2023.3.2 IDE launched by RunIdeBase task has the wrong platform prefix, it's always JetBrainsClient.
It happens because this code finds -Didea.platform.prefix=JetBrainsClient param in bin/jetbrains_client.sh file of IDE artifact and it considers JetBrainsClient as IDE platform prefix.

As a result, any checks based on platform prefix, for example, all checks in com.intellij.util.PlatformUtils, work unexpectedly for such IDE instances.

Relevant log output or stack trace

No response

Steps to reproduce

Add val platformPrefix = PlatformUtils.getPlatformPrefix() anywhere using 2023.3.2 IDE builds and check value

Gradle IntelliJ Plugin version

1.16.1

Gradle version

8.5

Operating System

macOS

Link to build, i.e. failing GitHub Action job

No response

@Undin Undin added the bug label Jan 11, 2024
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 11, 2024
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 11, 2024
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 11, 2024
@hsz hsz added this to the next milestone Jan 12, 2024
@hsz
Copy link
Member

hsz commented Jan 12, 2024

The issue is caused by improper shell script scanning to discover the platform prefix.
This should not happen, as 2022.3 explicitly provides such value through the product-info.json file.
Added proper platform version check.

@hsz hsz closed this as completed Jan 12, 2024
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 20, 2024
And drop all workarounds which are redundant anymore since the corresponding bugs are fixed in the plugin itself: JetBrains/intellij-platform-gradle-plugin#1515 and JetBrains/intellij-platform-gradle-plugin#1525
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 26, 2024
Undin added a commit to JetBrains/educational-plugin that referenced this issue Jan 26, 2024
And drop all workarounds which are redundant anymore since the corresponding bugs are fixed in the plugin itself: JetBrains/intellij-platform-gradle-plugin#1515 and JetBrains/intellij-platform-gradle-plugin#1525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants