Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External plugin dependency files present in plugin sandbox #172

Closed
baron1405 opened this issue Feb 9, 2017 · 0 comments
Closed

External plugin dependency files present in plugin sandbox #172

baron1405 opened this issue Feb 9, 2017 · 0 comments
Assignees
Milestone

Comments

@baron1405
Copy link
Contributor

External plugin dependencies that are not packaged as JAR files, can result in files from that dependency leaking into the plugin sandbox. To reproduce:

  1. Create a plugin
  2. Add an external dependency on CheckStyle-IDEA 5.1.4 (or whatever the current version)
  3. Build the plugin
  4. Notice that various files from the CheckStyle-IDEA plugin are present in the build/idea-sandbox/plugins/<plugin name>/lib directory

From debugging the code, it appears that the external dependency classes and META-INF directories are reported by Gradle with a trailing /. whereas the plugin dependencies directories in librariesToIgnore do not have the trailing slash. So the exclusion fails and the artifacts are left in the plugin bundle.

@zolotov zolotov self-assigned this Feb 13, 2017
@zolotov zolotov added this to the 0.2.2 milestone Feb 13, 2017
zolotov added a commit that referenced this issue Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants