Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch IDE with local plugin dependency #258

Closed
Undin opened this issue Jan 29, 2018 · 6 comments
Closed

Launch IDE with local plugin dependency #258

Undin opened this issue Jan 29, 2018 · 6 comments
Labels
duplicate

Comments

@Undin
Copy link
Contributor

Undin commented Jan 29, 2018 •
edited
Loading

Currently, gradle-intellij-plugin allows adding a dependency on some other plugin. And if plugin dependency is bundled or from plugin repo, new instance of IDE (launched by runIde task) has this plugin installed. But when dependency is another local plugin project, IDE instance doesn't have it.

It would be great to support this case.

For example, it would be useful for intellij-rust plugin where rust plugin has dependency on toml plugin
@zolotov
Copy link
Member

zolotov commented Jan 29, 2018

There is a composite-plugin example and it works as expected. Please check Rust build script.

@Undin
Copy link
Contributor Author

Undin commented Feb 2, 2018

Sorry for slow response
Looks like this feature works only with 0.3.0-SNAPSHOT version and doesn't work with 0.2.18
Do I understand correctly that #238 brought the fix to make this feature work but current stable plugin version doesn't contain it?

@zolotov
Copy link
Member

zolotov commented Feb 4, 2018

@Undin it looks so

@Undin
Copy link
Contributor Author

Undin commented Feb 4, 2018

Is there any estimation when this feature will be landed in stable?

@zolotov
Copy link
Member

zolotov commented Feb 5, 2018

not really, you can try backport it to 0.2 branch

@zolotov
Copy link
Member

zolotov commented Feb 5, 2018

duplicates #238

@zolotov zolotov closed this as completed Feb 5, 2018
@zolotov zolotov added duplicate and removed invalid labels Feb 5, 2018
kumbayo added a commit to kumbayo/intellij-rust that referenced this issue Feb 26, 2018
@kumbayo
Add a workaround for loading of the intellij-toml plugin
a9f9428 
The current way (since intellij-rust#2213) of loading the intellij-toml plugin
from build.gradle.kts requires a fix for
JetBrains/intellij-platform-gradle-plugin#238.
But the current latest stable version 0.2.18 of gradle-intellij-plugin
does not yet contain this fix.
This causes toml support to not work during development.

Go back to the old way of loading the intellij-toml plugin
until a bugfix version of intellij-toml containing the fix is released.

See JetBrains/intellij-platform-gradle-plugin#258 for more details.
@kumbayo kumbayo mentioned this issue Feb 26, 2018
Merged
bors bot added a commit to intellij-rust/intellij-rust that referenced this issue Feb 27, 2018
@bors
Merge #2334
a145666 
2334: Add a workaround for loading of the intellij-toml plugin r=Undin a=kumbayo

The current way (since #2213) of loading the intellij-toml plugin
from build.gradle.kts requires a fix for
JetBrains/intellij-platform-gradle-plugin#238.
But the current latest stable version 0.2.18 of gradle-intellij-plugin
does not yet contain this fix.
This causes toml support to not work during development.

Go back to the old way of loading the intellij-toml plugin
until a bugfix version of intellij-toml containing the fix is released.

See JetBrains/intellij-platform-gradle-plugin#258 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zolotov @Undin