Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find builtin plugin JavaScript with 212 (2021.2 EAP) IDE dependency #674

Closed
Undin opened this issue May 26, 2021 · 11 comments
Closed
Assignees
Labels
Milestone

Comments

@Undin
Copy link
Contributor

Undin commented May 26, 2021

The plugin shows error when I try to load a plugin project

Cannot create plugin from file (/Users/Arseniy.Pendryak/Programming/intellij-rust/deps/ideaIU-212.3116-EAP-CANDIDATE-SNAPSHOT/plugins/JavaScriptLanguage):
Invalid plugin descriptor 'plugin.xml': failed to resolve <xi:include>.
Not found document 'intellij.javascript.web.xml' referenced in <xi:include href="intellij.javascript.web.xml", xpointer="xpointer(/idea-plugin/*)"/>.
<xi:fallback> element is not provided. (at plugin.xml)

As a result, it's impossible to build plugins for 212 EAPs using gradle-intellij-plugin

Important details:

  • gradle-intellij-plugin 0.7.3
  • 212 IDEA Ultimate dependency (212.3116-EAP-CANDIDATE-SNAPSHOT)
  • JavaScript plugin dependency

Test project can be found here

I suppose the root of the problem is a movement of META-INF/web-platform.xml to intellij.javascript.web.xml (i.e. to top level in the corresponding jar file).
As a result, com.jetbrains.plugin.structure.intellij.plugin.IdePluginManager#createPlugin(java.nio.file.Path, boolean, java.lang.String) fails to find intellij.javascript.web.xml. Not sure, it's an issue of the platform or org.jetbrains.intellij.plugins:structure-intellij dependency

Related to #608

@zolotov
Copy link
Member

zolotov commented May 26, 2021

I suppose the root of the problem is a movement of META-INF/web-platform.xml to intellij.javascript.web.xml (i.e. to top level in the corresponding jar file).

I think all of them should be in the same jar
image

@serejke @hsz any ideas?

@Undin
Copy link
Contributor Author

Undin commented May 26, 2021

I think all of them should be in the same jar

They are in the same jar.
But there is a difference between 211 and 212. Although, I am not sure if it matters.

211 212
image image
image image

Undin added a commit to intellij-rust/intellij-rust that referenced this issue May 26, 2021
@zolotov
Copy link
Member

zolotov commented May 26, 2021

I think it should be inside META-INF or to be referenced in some other way rather than just intellij.javascript.web.xml. I suppose it may not work in the IntelliJ production as well. @piotrtomiak what do you think?

@piotrtomiak
Copy link
Contributor

@zolotov The change has been introduced by @develar in commit from 27.03.2021 and it's possible that there were some other changes to plugin classloading rules recently, which resulted in the aforementioned issue. I don't really know how to fix this, or why @develar moved the plugin descriptor out of META-INF, as intellij.javascript.web is a "virtual" module. In the build it's merged with JavaScript plugin and IMHO intellij.javascript.web.xml should be located in the same place as js-css.xml and other additional descriptors included from plugin.xml.

@zolotov
Copy link
Member

zolotov commented May 27, 2021

My point is that it's an unlikely problem for the gradle-intellij-plugin and probably even the problem of the JavaScript plugin for IntelliJ. @piotrtomiak could you please investigate that together with @develar, or probably you know the better candidate to take this over?

@piotrtomiak
Copy link
Contributor

@zolotov, agreed that this is most likely not a Gradle plugin problem. @develar, can you have a look?

Undin added a commit to intellij-rust/intellij-rust that referenced this issue May 28, 2021
Undin added a commit to intellij-rust/intellij-rust that referenced this issue May 28, 2021
@YannCebron YannCebron changed the title Cannot find builtin plugin JavaScript with 212 IDE dependency Cannot find builtin plugin JavaScript with 212 (2021.2 EAP) IDE dependency May 31, 2021
@YannCebron YannCebron pinned this issue May 31, 2021
Undin added a commit to intellij-rust/intellij-rust that referenced this issue May 31, 2021
bors bot added a commit to intellij-rust/intellij-rust that referenced this issue May 31, 2021
7259: Support 2021.2 EAPs r=Undin a=Undin

Note, `js` module won't be included in 212 build because of JetBrains/intellij-platform-gradle-plugin#674

changelog: Support 2021.2 EAPs


Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
Co-authored-by: vlad20012 <beskvlad@gmail.com>
@hsz hsz added the bug label May 31, 2021
mchernyavsky pushed a commit to intellij-rust/intellij-rust that referenced this issue May 31, 2021
@ARostovsky
Copy link
Contributor

I also faced this issue, @develar ping

@Undin
Copy link
Contributor Author

Undin commented Jun 29, 2021

Any updates?
ping @develar

@izhangzhihao
Copy link
Contributor

Any progress?

@chrkv chrkv self-assigned this Jul 9, 2021
@zolotov zolotov modified the milestones: 0.1.3, 1.1.3 Jul 12, 2021
hsz pushed a commit that referenced this issue Jul 12, 2021
@hsz
Copy link
Member

hsz commented Jul 14, 2021

The fix is now available in v1.1.3.

bors bot added a commit to intellij-rust/intellij-rust that referenced this issue Jul 15, 2021
7527: Enable js module for 2021.2 builds r=avrong a=Undin

Previously, the corresponding module was excluded from 2021.2 builds because of JetBrains/intellij-platform-gradle-plugin#674 that was fixed in 1.1.3

changelog: Enable [Go to generated declaration](https://plugins.jetbrains.com/plugin/8182-rust/docs/wasm-projects-support.html#goto-wasm-bindgen) line marker in WASM projects for 2021.2 platform


Co-authored-by: Arseniy Pendryak <a.pendryak@yandex.ru>
vepanimas added a commit to JetBrains/js-graphql-intellij-plugin that referenced this issue Jul 19, 2021
@hsz hsz unpinned this issue Jun 9, 2022
@changety
Copy link

changety commented Jul 16, 2022

My IDEA version is 2022.1, I also meet this issue :

Cannot find builtin plugin 'JavaScript' for IDE: ~/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.idea/ideaIC/2021.2/b0727ceddea2b62b16825db9308e14a470198e7f/ideaIC-2021.2

the step how to recurrence the issue:

step 1:

Use Idea's [new project], and new a plugin project

step 2:

    <depends>JavaScript</depends> in plugin.xml

step 3:

    plugins.set(listOf("JavaScript")) in build.gradle.ktx

and this issue happen.....
image

Any Solution?

UPDATE:
// type.set("IC")
this is the reason why this issue happen in my case, cause IC do not have the build in plugin 'JavaScript', when I switch
to IU, issue solved~~

intellij {
    version.set("2021.2")
    // type.set("IC")   this is the reason why this issue happen in my case,  cause IC  do not have the build in plugin 'JavaScript', when I switch to IU,  issue solved~~
    type.set("IU") // Target IDE Platform

    plugins.set(listOf("JavaScript"))
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants