Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled JBR not being used when runIde task is run with ideDir argument #756

Closed
grmoon opened this issue Jul 29, 2021 · 1 comment
Closed
Assignees
Labels
Milestone

Comments

@grmoon
Copy link

grmoon commented Jul 29, 2021

OS: Mac OS X
Plugin Version: 1.1.3

On Mac OS X, running the runIde task with ideDir param does not automatically use bundled JBR as specified here.

Using alternativeIdePath before it was replaced with ideDir in the 1.x release correctly resolved the JBR bundled with the specified IDE and ran the development instance using that JBR.

From what I can tell, this is a result of changes made to IntelliJPlugin.groovy/IntelliJPlugin.kt

IntelliJPlugin.groovy (Old)

https://github.com/JetBrains/gradle-intellij-plugin/blob/3a07e1ea7cdab9bbec6ab3e7b0c95239fcc62e0b/src/main/groovy/org/jetbrains/intellij/IntelliJPlugin.groovy#L436-L463

IntelliJPlugin.kt (New)

https://github.com/JetBrains/gradle-intellij-plugin/blob/530bd504d94960c039222367882addecaa98d522/src/main/kotlin/org/jetbrains/intellij/IntelliJPlugin.kt#L699-L718

@hsz hsz self-assigned this Jul 30, 2021
@hsz hsz added this to the next milestone Aug 31, 2021
@hsz
Copy link
Member

hsz commented Aug 31, 2021

Thanks for reporting, Gregory! It's fixed and will be available with the upcoming release.

@hsz hsz closed this as completed Aug 31, 2021
@hsz hsz added the bug label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants