Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish gradle-intellij-plugin sources #810

Closed
jonnyzzz opened this issue Oct 16, 2021 · 6 comments
Closed

Publish gradle-intellij-plugin sources #810

jonnyzzz opened this issue Oct 16, 2021 · 6 comments
Assignees
Milestone

Comments

@jonnyzzz
Copy link
Member

Related to https://youtrack.jetbrains.com/issue/IDEA-280494

I use the IntelliJ plugin SDK plugin in the Gradle project.
Navigation to symbols opens the decompiled declarations, rather than sources.
It breaks us from reading the code comments in the plugin sources, killing all the benefits of build.gradle.kts.

It actually seems like we do not publish sources at all, just take a look at:
https://plugins.gradle.org/m2/org/jetbrains/intellij/plugins/gradle-intellij-plugin/1.2.0/

image

@hsz hsz self-assigned this Oct 16, 2021
hsz added a commit that referenced this issue Oct 20, 2021
@hsz hsz added this to the next milestone Oct 20, 2021
@hsz hsz closed this as completed Oct 20, 2021
@jonnyzzz
Copy link
Member Author

Thanks for the fix. What release is it going to be included?

@hsz hsz reopened this Oct 26, 2021
@hsz hsz modified the milestone: next Oct 26, 2021
@hsz hsz removed this from the 1.3.0 milestone Nov 15, 2021
@kagof
Copy link

kagof commented Mar 21, 2022

It looks like the archiveClassifier lines were removed in this commit (perhaps accidentally?). @hsz would it be possible to add these lines back in?

I'd be happy to raise a PR to do so if you're busy.

@hsz
Copy link
Member

hsz commented Mar 21, 2022

@kagof Both sourcesJar and javadocJar have the archiveClassifier specified in the upper scope:

https://github.com/JetBrains/gradle-intellij-plugin/blob/7eef9e2959c389773a7da79be0b8b054b7ddfca4/build.gradle.kts#L124-L135

@kagof
Copy link

kagof commented Mar 25, 2022

Ah, my mistake, sorry. So I guess it's unknown why the sources aren't being published then?

@hsz
Copy link
Member

hsz commented Mar 25, 2022

Yeah, TBH I'm confused about that.

@YannCebron YannCebron changed the title Publish plugin sources Publish gradle-intellij-plugin sources Apr 26, 2022
@hsz
Copy link
Member

hsz commented May 20, 2022

It turned out this was an issue in com.gradle.plugin-publish plugin.
After upgrading it to 1.0.0-rc-2, all additional artifacts – sources and docs – are now considered.

@hsz hsz closed this as completed May 20, 2022
@hsz hsz added this to the next milestone May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants