Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of using jbrVersion to use a JBR variant I propose a jbrVariant #852

Closed
bric3 opened this issue Dec 2, 2021 · 2 comments
Closed
Assignees
Milestone

Comments

@bric3
Copy link
Contributor

bric3 commented Dec 2, 2021

Since 1.3.0 we can use multiple variant of the JBR, see #818. However the current approach allow this by specifying the whole version.

This approach has some drawback as it requires plugin developers to make sure the JBR is compatible with the base IntelliJ version, point in case :

If I want to use the latest Java 11 with DCEVM I will likely enter this version jbr_dcevm-11_0_13b1751.19, however IntelliJ 2021.1 isn't compatible with this JBR (there's no access to application Preferences). For IntelliJ 2021.1.3 you need to use jbr_dcevm-11_0_11b1341.60.

This makes the whole development brittle as this require to constantly check the JBR version matches with current IntelliJ version.

I believe a simpler approach for us to consume is to be able to indicate the runtime variant (dcevm, fastdebug, etc), and let gradle-intellij-plugin find the correct runtime version.

@hsz hsz self-assigned this Dec 2, 2021
@hsz hsz added the enhancement label Dec 2, 2021
@hsz hsz added this to the next milestone Feb 7, 2022
hsz added a commit that referenced this issue Feb 7, 2022
…`runIde`, `runPluginVerifier`, `buildSearchableOptions`, and `runIdeForUiTest` tasks #852
@hsz
Copy link
Member

hsz commented Feb 7, 2022

@bric3 Thanks for the suggestion – it's now implemented and will be available with the following 1.4.0 release.

@hsz hsz closed this as completed Feb 7, 2022
@bric3
Copy link
Contributor Author

bric3 commented Feb 7, 2022

Cool thank you @hsz
Now I'll keep my eyes on the 1.5 hot swap agent (@skybber awesomely added support for IJ).

Salomon88 pushed a commit to Salomon88/gradle-intellij-plugin that referenced this issue Feb 18, 2022
…`runIde`, `runPluginVerifier`, `buildSearchableOptions`, and `runIdeForUiTest` tasks JetBrains#852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants