Avoid unnecessary task configuration #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsz
force-pushed
the
avoid-configuration
branch
from
c091b2d
to
e13d6ea
Compare
This method will cause all tasks in this container to be realized, which on project.tasks means every task in the project will be configured when the plugin is applied.
Using forEach on a TaskCollection will eagerly realise those tasks. Using Gradle's configureEach will avoid realising the tasks unless they will run as part of the build.
3flex
force-pushed
the
avoid-configuration
branch
from
ab1cdf4
to
d8e4f19
Compare
|
@hsz I've rebased on master which now passes CI, and the test that was failing after your last commit succeeds locally, so I'm hopeful this is OK to go though the workflow won't run without a maintainer approval given I'm a first-time contributor. Happy to address any issues, just let me know how best to help, thanks! |
|
@3flex Thanks a lot for your PR – an outstanding finding! |
… execution (JetBrains#1108) * Do not move resource directories to the end of classpath (JetBrains#1101) * Do not move resource directories to the end of classpath (JetBrains#1101) - add integration test * Do not move resource directories to the end of classpath (JetBrains#1101) - include in CHANGES.md * Do not move resource directories to the end of classpath (JetBrains#1101) - cosmetics * Bump jackson-databind from 2.13.3 to 2.13.4 Bumps [jackson-databind](https://github.com/FasterXML/jackson) from 2.13.3 to 2.13.4. - [Release notes](https://github.com/FasterXML/jackson/releases) - [Commits](https://github.com/FasterXML/jackson/commits) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-databind dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump structure-intellij from 3.236 to 3.237 Bumps [structure-intellij](https://github.com/JetBrains/intellij-plugin-verifier) from 3.236 to 3.237. - [Release notes](https://github.com/JetBrains/intellij-plugin-verifier/releases) - [Commits](JetBrains/intellij-plugin-verifier@intellij-structure-3.236...intellij-structure-3.237) --- updated-dependencies: - dependency-name: org.jetbrains.intellij.plugins:structure-intellij dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump structure-base from 3.236 to 3.237 Bumps [structure-base](https://github.com/JetBrains/intellij-plugin-verifier) from 3.236 to 3.237. - [Release notes](https://github.com/JetBrains/intellij-plugin-verifier/releases) - [Commits](JetBrains/intellij-plugin-verifier@intellij-structure-3.236...intellij-structure-3.237) --- updated-dependencies: - dependency-name: org.jetbrains.intellij.plugins:structure-base dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump dd-plist from 1.24 to 1.25 Bumps [dd-plist](https://github.com/3breadt/dd-plist) from 1.24 to 1.25. - [Release notes](https://github.com/3breadt/dd-plist/releases) - [Commits](3breadt/dd-plist@v1.24.0...v1.25.0) --- updated-dependencies: - dependency-name: com.googlecode.plist:dd-plist dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Integration Tests: Add missing entries to README file * Invalidate instrumented classes bound to forms if GUI changed [IDEA-298989](https://youtrack.jetbrains.com/issue/IDEA-298989/Duplicate-method-name-getFont) * Integration Tests: extend classpath test with JaCoCo integration * build.gradle.kts: move configuration values to `gradle.properties` file * Bump `javax.xml.bind:jaxb-api` dependency to `2.4.0-b180830.0359` * IntelliJInstrumentCodeTask.kt: make sure `instrumentedClassPath` exists before replacing it with `compiledClassPath` Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Chrzanowski <jakub.chrzanowski@jetbrains.com>
|
Thanks again, Matthew! That was a nice change to the project. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
I noticed in a project that uses this plugin that many tasks were created during the configuration phase which seemed unnecessary.
Description
I have applied various techniques to avoid unnecessary task configuration. As written here https://docs.gradle.org/current/userguide/task_configuration_avoidance.html:
Related Issue
#1110
Motivation and Context
Improves Gradle's performance.
How Has This Been Tested
Applying gradle-intellij-plugin using Gradle's composite build feature in the cashapp/sqldelight project which uses this plugin.
Types of changes
Checklist