Fix #1413: Replace deprecated JavaPluginConventions usage #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [JetBrains/qodana-action](https://github.com/JetBrains/qodana-action) from 2023.1.4 to 2023.1.5. - [Release notes](https://github.com/JetBrains/qodana-action/releases) - [Commits](JetBrains/qodana-action@v2023.1.4...v2023.1.5) --- updated-dependencies: - dependency-name: JetBrains/qodana-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
Thanks for the help on that, Róbert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Replaces
.conventionusage with.extensionandJavaPluginConventionwithJavaPluginExtension.JavaPluginExtensionwas added in Gradle 4.10. Consdering the docs say:this change should bear very low risk.
Related Issue
Fixes #1413
Motivation and Context
Gradle is removing long-deprecated conventions APIs in favor of extensions. In Gradle 8.2 (now in RC2) they added nagging so plugin users will be nagged but they can't action the nagging until there's a version of the plugin released which doesn't use conventions.
How Has This Been Tested
gradlew buildand
gradlew :publishSnapshotPublicationToMavenLocal+mavenLocal()repo, becauseincludeBuildapproach doesn't work as described in CONTRIBUTING.md.Types of changes
Checklist