Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus state not saved after selected state changed #31

Merged
merged 1 commit into from Dec 23, 2022

Conversation

devkanro
Copy link
Collaborator

The state remember by state, it will cause the focused state will not be saved when selected changed.

The behavior on the control is that when the checkbox is clicked with the mouse, the checkbox will not be displayed as focused.

This PR fixed it by not remember state by selected, then use another remember to update the selected state in state

Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rock3r rock3r merged commit 1843f59 into JetBrains:main Dec 23, 2022
@devkanro devkanro deleted the fix-cleared-focus branch December 23, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants