Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to the build files #442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor updates to the build files #442

wants to merge 1 commit into from

Conversation

rock3r
Copy link
Collaborator

@rock3r rock3r commented Jul 9, 2024

While I try to figure out what is happening with the IntelliJ Platform Gradle Plugin 2.01, I cleaned up the build scripts a bit. This should ensure that:

  1. We use the same major JDK version for buildSrc too
  2. We enforce the language version in the standalone sample too (it should come from the Jewel plugin, but it doesn't — possibly because we set a toolchain in the module, too)
  3. There are a couple less minor formatting issues than before
  4. We have one less unused function

Footnotes

  1. For whatever reason, using any JDK 21 as Gradle JVM results in a classloading error at runtime when trying to use any class from the bridge module (but not its transitive dependencies). Even though the code is run with a JDK 21, both in bridge and standalone, Gradle needs to run with a JDK 22 for things to not blow up at runtime.

@rock3r rock3r added the cleanup Improve the project/tooling and/or get rid of tech debt label Jul 9, 2024
@rock3r rock3r requested a review from lamba92 July 9, 2024 17:44
@rock3r rock3r self-assigned this Jul 9, 2024
@rock3r rock3r enabled auto-merge (squash) July 9, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Improve the project/tooling and/or get rid of tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant