-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Swift export #723
Open
sbogolepov
wants to merge
4
commits into
JetBrains:2.0.0-beta2-prepare
Choose a base branch
from
sbogolepov:swift-export-v1
base: 2.0.0-beta2-prepare
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Initial support for Swift export #723
sbogolepov
wants to merge
4
commits into
JetBrains:2.0.0-beta2-prepare
from
sbogolepov:swift-export-v1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0641af2
to
9a58408
Compare
nikpachoo
approved these changes
May 17, 2024
Minor hack: use wasm stdlib to avoid downloading the whole K/N distribution
21f01d3
to
a49ae3d
Compare
DO NOT MERGE IT. |
A note for the devs: in prod, we use "swift-export-v1" branch |
mMaxy
reviewed
Jun 3, 2024
SirAsSwiftSourcesPrinter.print( | ||
sirModule, | ||
stableDeclarationsOrder = true, | ||
renderDocComments = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be false - we do not support them currently, see KT-68744 for more information.
Are there any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
build.gradle.kts
.There might be bugs. We will squash them as soon as possible :)