Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes and basic syntax pages #4117

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Conversation

AlejandraPedroza
Copy link
Contributor

Update Classes page to mention variables when creating an instance, and update Variables section in Basic syntax page to mention initialization and more.

docs/topics/basic-syntax.md Show resolved Hide resolved
docs/topics/basic-syntax.md Outdated Show resolved Hide resolved
docs/topics/basic-syntax.md Show resolved Hide resolved
docs/topics/basic-syntax.md Show resolved Hide resolved
docs/topics/classes.md Outdated Show resolved Hide resolved
Copy link

@ice-phoenix ice-phoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlejandraPedroza AlejandraPedroza force-pushed the update-variables branch 2 times, most recently from 627adee to 7b99ab7 Compare April 15, 2024 11:37
@daniCsorbaJB daniCsorbaJB self-requested a review April 15, 2024 13:45
Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍 💯 - I left some comments

docs/topics/basic-syntax.md Outdated Show resolved Hide resolved
docs/topics/basic-syntax.md Outdated Show resolved Hide resolved
docs/topics/basic-syntax.md Show resolved Hide resolved
docs/topics/basic-syntax.md Outdated Show resolved Hide resolved
docs/topics/basic-syntax.md Show resolved Hide resolved
@@ -229,7 +272,7 @@ See [classes](classes.md) and [objects and instances](object-declarations.md).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line before that:
See classes and objects and instances.
could benefit from the same treatment you have given the links in the previous section.

For example, we talk about primary constructors but not about secondary constructors - we could lead users to classes to read more about that.

Copy link
Contributor

@daniCsorbaJB daniCsorbaJB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes - one last minor comment other LGTM 🚀

docs/topics/basic-syntax.md Outdated Show resolved Hide resolved
@AlejandraPedroza AlejandraPedroza merged commit 9f6f6c3 into master Apr 16, 2024
4 checks passed
@AlejandraPedroza AlejandraPedroza deleted the update-variables branch April 16, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants