-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update classes and basic syntax pages #4117
Conversation
e9ac157
to
f9e074c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
627adee
to
7b99ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍 💯 - I left some comments
@@ -229,7 +272,7 @@ See [classes](classes.md) and [objects and instances](object-declarations.md). | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line before that:
See classes and objects and instances.
could benefit from the same treatment you have given the links in the previous section.
For example, we talk about primary constructors but not about secondary constructors - we could lead users to classes to read more about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes - one last minor comment other LGTM 🚀
…n in basic syntax page to mention initialization and more.
104bfba
to
6c25bfd
Compare
Update Classes page to mention variables when creating an instance, and update Variables section in Basic syntax page to mention initialization and more.