Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI. Full style customization support via components' classes [generated] #2240

Merged
merged 5 commits into from
May 5, 2024

Conversation

aerialist7
Copy link
Contributor

No description provided.

Copy link
Collaborator

@turansky turansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please attach documentation/example links, which describe update?

@aerialist7
Copy link
Contributor Author

aerialist7 commented May 3, 2024

This is a fix for correct styling of the components.
See the "Styled components" section here – https://mui.com/base-ui/getting-started/customization/#which-option-to-choose
Here is the sample – https://codesandbox.io/p/sandbox/interesting-oskar-w89gtm?file=%2Fsrc%2FDemo.tsx

There was a problem in MUI Base only, because it has different class-name convention – instead of MuiComponent-modifier it uses base-Component-modifier.

Screenshot 2024-05-03 at 14 23 30

@aerialist7 aerialist7 requested a review from turansky May 3, 2024 11:28
Copy link
Collaborator

@turansky turansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switchClasses exists in runtime as I see.
External object switchClasses expected in declarations.

@aerialist7 aerialist7 requested a review from turansky May 4, 2024 17:31
@aerialist7 aerialist7 changed the title MUI. Base. Fix "classes" declarations [generated] MUI. Full style customization support via "classes" [generated] May 4, 2024
@aerialist7
Copy link
Contributor Author

switchClasses exists in runtime as I see. External object switchClasses expected in declarations.

Done

@aerialist7 aerialist7 changed the title MUI. Full style customization support via "classes" [generated] MUI. Full style customization support via components' classes [generated] May 4, 2024
@aerialist7 aerialist7 requested a review from turansky May 4, 2024 18:32
@aerialist7 aerialist7 requested a review from turansky May 5, 2024 09:10
@turansky turansky merged commit 2658e76 into JetBrains:master May 5, 2024
3 checks passed
@aerialist7 aerialist7 deleted the mui-base branch May 5, 2024 18:12
@aerialist7
Copy link
Contributor Author

@Leonya, could you please release these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants