Hold back eachSumOf for a while.

JetBrains · Jan 11, 2017 · 4816474 · 4816474
1 parent 0dfcbdf
commit 4816474
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/js/js.libraries/src/core/grouping.kt b/js/js.libraries/src/core/grouping.kt
@@ -24,11 +24,13 @@ package kotlin.collections
 public fun <T, K> Grouping<T, K>.eachCount(): Map<K, Int> =
         fold(0) { acc, e -> acc + 1 }
 
+/**
 /**
  * Groups elements from the [Grouping] source by key and sums values provided by the [valueSelector] function for elements in each group.
  *
  * @return a [Map] associating the key of each group with the count of element in the group.
  */
 @SinceKotlin("1.1")
 public inline fun <T, K> Grouping<T, K>.eachSumOf(valueSelector: (T) -> Int): Map<K, Int> =
-        fold(0) { acc, e -> acc + valueSelector(e) }
+        fold(0) { acc, e -> acc + valueSelector(e) }
+*/
diff --git a/libraries/stdlib/src/kotlin/collections/Grouping.kt b/libraries/stdlib/src/kotlin/collections/Grouping.kt
@@ -246,6 +246,7 @@ public fun <T, K> Grouping<T, K>.eachCount(): Map<K, Int> =
 public fun <T, K, M : MutableMap<in K, Int>> Grouping<T, K>.eachCountTo(destination: M): M =
         foldTo(destination, 0) { acc, _ -> acc + 1 }
 
+/**
 /**
  * Groups elements from the [Grouping] source by key and sums values provided by the [valueSelector] function for elements in each group.
  *
@@ -273,7 +274,7 @@ public inline fun <T, K> Grouping<T, K>.eachSumOf(valueSelector: (T) -> Int): Ma
 @SinceKotlin("1.1")
 public inline fun <T, K, M : MutableMap<in K, Int>> Grouping<T, K>.eachSumOfTo(destination: M, valueSelector: (T) -> Int): M =
         foldTo(destination, 0) { acc, e -> acc + valueSelector(e)}
-
+*/
 
 @JvmVersion
 @PublishedApi

diff --git a/libraries/stdlib/test/collections/GroupingTest.kt b/libraries/stdlib/test/collections/GroupingTest.kt
@@ -98,7 +98,7 @@ class GroupingTest {
         assertEquals(mapOf('f' to 2, 'b' to 3, 'a' to 1, 'z' to 2), counts2)
     }
 
-
+/**
     @Test fun sumEach() {
         val values = listOf("k" to 50, "b" to 20, "k" to 1000 )
         val summary = values.groupingBy { it.first }.eachSumOf { it.second }
@@ -110,4 +110,5 @@ class GroupingTest {
 
         assertEquals(mapOf("k" to 1053, "b" to 31, "a" to 5), summary2)
     }
+*/
 }