Retain data flow info after try-finally

JetBrains · Nov 16, 2012 · ef3e380 · ef3e380
1 parent d629fe2
commit ef3e380
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 3 deletions.
diff --git a/.../frontend/src/org/jetbrains/jet/lang/types/expressions/ControlStructureTypingVisitor.java b/.../frontend/src/org/jetbrains/jet/lang/types/expressions/ControlStructureTypingVisitor.java
@@ -425,18 +425,22 @@ public JetTypeInfo visitTryExpression(JetTryExpression expression, ExpressionTyp
                 }
             }
         }
+
+        DataFlowInfo dataFlowInfo = context.dataFlowInfo;
         if (finallyBlock != null) {
-            facade.getTypeInfo(finallyBlock.getFinalExpression(), context.replaceExpectedType(TypeUtils.NO_EXPECTED_TYPE));
+            dataFlowInfo = facade.getTypeInfo(finallyBlock.getFinalExpression(),
+                                              context.replaceExpectedType(TypeUtils.NO_EXPECTED_TYPE)).getDataFlowInfo();
         }
+
         JetType type = facade.getTypeInfo(tryBlock, context).getType();
         if (type != null) {
             types.add(type);
         }
         if (types.isEmpty()) {
-            return JetTypeInfo.create(null, context.dataFlowInfo);
+            return JetTypeInfo.create(null, dataFlowInfo);
         }
         else {
-            return JetTypeInfo.create(CommonSupertypes.commonSupertype(types), context.dataFlowInfo);
+            return JetTypeInfo.create(CommonSupertypes.commonSupertype(types), dataFlowInfo);
         }
     }
 

diff --git a/compiler/testData/diagnostics/tests/dataFlowInfoTraversal/TryFinally.kt b/compiler/testData/diagnostics/tests/dataFlowInfoTraversal/TryFinally.kt
@@ -0,0 +1,19 @@
+fun tryFinally(x: Int?) {
+    try {
+    } finally {
+        x!!
+    }
+    x : Int
+}
+
+fun tryCatchFinally(x: Int?) {
+    try {
+        x!!
+    } catch (e: Exception) {
+        x!!
+    } finally {
+        <!TYPE_MISMATCH!>x<!> : Int
+        x!!
+    }
+    x : Int
+}
diff --git a/compiler/tests/org/jetbrains/jet/checkers/JetDiagnosticsTestGenerated.java b/compiler/tests/org/jetbrains/jet/checkers/JetDiagnosticsTestGenerated.java
@@ -1296,6 +1296,11 @@ public void testTryCatch() throws Exception {
                 doTest("compiler/testData/diagnostics/tests/dataFlowInfoTraversal/TryCatch.kt");
             }
 
+            @TestMetadata("TryFinally.kt")
+            public void testTryFinally() throws Exception {
+                doTest("compiler/testData/diagnostics/tests/dataFlowInfoTraversal/TryFinally.kt");
+            }
+
             @TestMetadata("UnaryExpression.kt")
             public void testUnaryExpression() throws Exception {
                 doTest("compiler/testData/diagnostics/tests/dataFlowInfoTraversal/UnaryExpression.kt");