Add test cases for constructors with SFVC as a parameter.
#5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k163377
force-pushed
the
test/value-class-call-by
branch
from
a0626d9
to
8c2e044
Compare
k163377
commented
Feb 23, 2024
compiler/testData/codegen/box/reflection/callBy/inlineClassDefaultArguments.kt
Outdated
Show resolved
Hide resolved
...n/callBy/valueClasses/nonNullObject/defaultArguments/constructorWithInlineClassParameters.kt
Show resolved
Hide resolved
Comment on lines
+8
to
+10
| data class TestCtor1_1(val x: A = A("0")) | ||
| data class TestCtor1_2(val x: A? = A("0")) |
There was a problem hiding this comment.
I am adding a function to verify the nullability of a parameter.
Should I add a case where the default argument is null?
|
@udalov |
ilmirus
requested changes
Feb 23, 2024
...n/callBy/valueClasses/nonNullObject/defaultArguments/constructorWithInlineClassParameters.kt
Outdated
Show resolved
Hide resolved
k163377
commented
Feb 23, 2024
.../callBy/valueClasses/nullableObject/defaultArguments/constructorWithInlineClassParameters.kt
Show resolved
Hide resolved
k163377
added a commit
to k163377/kotlin
that referenced
this pull request
Feb 23, 2024
k163377
added a commit
to k163377/kotlin
that referenced
this pull request
Apr 21, 2024
k163377
added a commit
to k163377/kotlin
that referenced
this pull request
Apr 21, 2024
k163377
force-pushed
the
test/value-class-call-by
branch
from
ba8ba1d
to
8880205
Compare
|
Too much time had passed, so I |
k163377
added a commit
to k163377/kotlin
that referenced
this pull request
Apr 26, 2024
udalov
force-pushed
the
test/value-class-call-by
branch
from
ced6ebc
to
5ccc8d7
Compare
|
Sorry for delays, merged in 0ed4cab. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed missing test cases regarding the type that
value classwraps and nullability as a parameter.For
SFCV, these test cases are largely missing.I would like to continue to contribute to the completion of such test cases.
By the way, are there any rules on how to write commit messages?
Also, are there any recommended per-commit guidelines?
I have had these corrected several times and I apologize for that.