Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stubs for ext-mongodb 1.16 #1553

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Jun 20, 2023

This PR updates the stubs for the MongoDB extension.

This PR updates the function map to include method signatures for ext-mongodb 1.16.

Notable changes:

  • Added MongoDB\BSON\Document, MongoDB\BSON\Iterator, and MongoDB\BSON\PackedArray classes
  • Made constructor for MongoDB\BSON\Int64 public
  • Added MongoDB\Driver\WriteResult::getErrorReplies
  • Added missing stubs in for MongoDB\Driver\ClientEncryption

@alcaeus
Copy link
Contributor Author

alcaeus commented Jun 29, 2023

Note: test failures are unrelated to the changes from this PR.

@GromNaN
Copy link
Contributor

GromNaN commented Jun 30, 2023

@alcaeus There are missing updates from 1.15. At least MongoDB\BSON\Binary::__constructor() 2nd argument is optional since mongodb/mongo-php-driver#1362

@alcaeus
Copy link
Contributor Author

alcaeus commented Jul 4, 2023

Updated stubs to represent typing changes. The last commit also adds all SDAM monitoring classes and some other stubs that where previously missed.

@isfedorov
Copy link
Member

@alcaeus Thank you!

@isfedorov isfedorov merged commit 3bb9c8a into JetBrains:master Jul 14, 2023
10 checks passed
@alcaeus alcaeus deleted the mongodb-1.16-stubs branch July 14, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants