fix(amqp): many parameters of the name and some types, as well as the… #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2024 16:34
… return of the value have changed A simple example: in v1.11.0, the bool values were increased - https://github.com/php-amqp/php-amqp/blob/v1.11.0/stubs/AMQPExchange.php#L173 https://github.com/php-amqp/php-amqp/blob/v1.11.0/amqp_exchange.c#L636 since version v2 it has become void - https://github.com/php-amqp/php-amqp/blob/v2.0.0/stubs/AMQPExchange.php#L195 https://github.com/php-amqp/php-amqp/blob/v2.0.0/amqp_exchange.c#L672 Link to stubs: https://github.com/php-amqp/php-amqp/tree/latest/stubs
… return of the value have changed A simple example: in v1.11.0, the bool values were increased - https://github.com/php-amqp/php-amqp/blob/v1.11.0/stubs/AMQPExchange.php#L173 https://github.com/php-amqp/php-amqp/blob/v1.11.0/amqp_exchange.c#L636 since version v2 it has become void - https://github.com/php-amqp/php-amqp/blob/v2.0.0/stubs/AMQPExchange.php#L195 https://github.com/php-amqp/php-amqp/blob/v2.0.0/amqp_exchange.c#L672 Link to stubs: https://github.com/php-amqp/php-amqp/tree/latest/stubs
isfedorov
requested changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… return of the value have changed
A simple example:
in v1.11.0, the bool values were increased -
https://github.com/php-amqp/php-amqp/blob/v1.11.0/stubs/AMQPExchange.php#L173 https://github.com/php-amqp/php-amqp/blob/v1.11.0/amqp_exchange.c#L636 since version v2 it has become void - https://github.com/php-amqp/php-amqp/blob/v2.0.0/stubs/AMQPExchange.php#L195 https://github.com/php-amqp/php-amqp/blob/v2.0.0/amqp_exchange.c#L672
Link to stubs:
https://github.com/php-amqp/php-amqp/tree/latest/stubs