add / fix some phpdocs #892
Conversation
+ fix some return types + normalize the param phpdocs + normalize the "php.net" links (language "en" as default)
interbase/interbase.php
Outdated
| * @return string the name of the event that was posted. | ||
| */ | ||
| function ibase_wait_event ($event_name1, $event_name2 = null, $_ = null) {} | ||
| function ibase_wait_event (...$event_names) {} |
There was a problem hiding this comment.
I can't find any proofs of this. Have you checked this?
There was a problem hiding this comment.
Yes, but it's not 100% correct in both cases. :-/
ibase_wait_event ( string ...$event_names) : string
ibase_wait_event ( resource $link_identifier, string ...$event_names) : string
standard/standard_4.php
Outdated
| * @return void | ||
| */ | ||
| function var_dump ($expression, $_ = null) {} | ||
| function var_dump (...$expressions) {} |
There was a problem hiding this comment.
it's not the same because it also means that I can use this function without any arguments but actually I can't. Could you also check other similar changes?
There was a problem hiding this comment.
You are right, checked and reverted. 👍
|
@voku please, take a look at tests, seems some tests are broken after adding |
|
@slapoguzov I tried to fix this problem upstream (phpDocumentor/ReflectionDocBlock#254) or is this behavior expected? |
|
@voku I think it's a bug in phpDocumentor. I suggest excluding changes that break tests from this MR and merge it. And you can open a new MR with these changes when the problem in phpDocumentor is resolved. |
|
@slapoguzov the bug in phpDocumentor is fixed :) |
manually sync with "https://github.com/php/php-src/blob/master/ext/intl/php_intl.stub.php" ... maybe we can automate this?
No description provided.