Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial attempt at ReplaceReturnTypeFix. #367

Merged
merged 32 commits into from Jun 8, 2022
Merged

Initial attempt at ReplaceReturnTypeFix. #367

merged 32 commits into from Jun 8, 2022

Commits on Jun 8, 2022

  1. Initial attempt at ReplaceReturnTypeFix.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    0fb183f View commit details
    Browse the repository at this point in the history

  2. Enable ReplaceReturnTypeFix quickfix for error FS0001: The type 'doub… 

    …le' does not match the type 'int' as well.
    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    4ddcfcb View commit details
    Browse the repository at this point in the history

  3. Only visit parent of Sequential if expr is last item.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    4aea04f View commit details
    Browse the repository at this point in the history

  4. Allow fix when expression is body of SynMatchClause.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    f2f3cfb View commit details
    Browse the repository at this point in the history

  5. Add initial quick fix tests.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    c421202 View commit details
    Browse the repository at this point in the history

  6. Add failing test to restore return type.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    6f7df23 View commit details
    Browse the repository at this point in the history

  7. Only replace TypeUsage from ReturnType.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    d4e2d3c View commit details
    Browse the repository at this point in the history

  8. Refactor quick fix to use FSharpExpressionUtil.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    adb9812 View commit details
    Browse the repository at this point in the history

  9. Add negative tests.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    9a00e80 View commit details
    Browse the repository at this point in the history

  10. Add some more tests.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    5c2de3e View commit details
    Browse the repository at this point in the history

  11. Refactor GetOuterMostParentExpression to use Navigator helpers.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    44aebcd View commit details
    Browse the repository at this point in the history

  12. Add negative test for record field expression.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    8ddf350 View commit details
    Browse the repository at this point in the history

  13. Remove For- and WhileExprNavigator.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    5f5168e View commit details
    Browse the repository at this point in the history

  14. Remove definition of FooAttribute.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    7cd784e View commit details
    Browse the repository at this point in the history

  15. Replace MatchExprNavigator with MatchClauseListOwnerExprNavigator.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    58921d1 View commit details
    Browse the repository at this point in the history

  16. Rename and group unit tests.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    abac5d5 View commit details
    Browse the repository at this point in the history

  17. Add test for LetOrUse.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    23d1071 View commit details
    Browse the repository at this point in the history

  18. Add tests for IfThenElse.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    678ed64 View commit details
    Browse the repository at this point in the history

  19. Accept the replacement type in the constructor of ReplaceReturnTypeFix.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    31f1462 View commit details
    Browse the repository at this point in the history

  20. Add tests for function type return type.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    b130065 View commit details
    Browse the repository at this point in the history

  21. Add newline to end of test data files.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    40133b7 View commit details
    Browse the repository at this point in the history

  22. Parentheses around the return type.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    516eae3 View commit details
    Browse the repository at this point in the history

  23. Tuple return type, where one type doesn't match.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    e5b9609 View commit details
    Browse the repository at this point in the history

  24. Tuple return type, mismatch in number of items, to few in return type.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    b395f15 View commit details
    Browse the repository at this point in the history

  25. Add test for too many items in tuple return type.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    e76f69e View commit details
    Browse the repository at this point in the history

  26. Don't assume type to replace a tuple with is also a tuple.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    dba882e View commit details
    Browse the repository at this point in the history

  27. Verify if the closest parent is a tuple expr to see if the items match.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    f5ea03c View commit details
    Browse the repository at this point in the history

  28. Replace function type with tuple.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    153184b View commit details
    Browse the repository at this point in the history

  29. Remove tuple and lambda support.

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    6197440 View commit details
    Browse the repository at this point in the history

  30. Mark tests as not available

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    b745a59 View commit details
    Browse the repository at this point in the history

  31. Renamed helper function GetOutermostParentExpressionFromItsReturn

    @nojaf @auduchinok
    nojaf authored and auduchinok committed Jun 8, 2022
    Copy the full SHA
    fa7389a View commit details
    Browse the repository at this point in the history

  32. Disable quick fix via highlighting registration

    @auduchinok
    auduchinok committed Jun 8, 2022
    Copy the full SHA
    88396a2 View commit details
    Browse the repository at this point in the history