You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I looked into decompiled code I saw that it just returns private member so it brings one indirection level (which can be optimized by compiler). I consider this is quite non-essential microoptimization. But introducing local variable for a lot of simple cases readability can easily be reduced (not always, of course) so there is a negative impact on this fix as well. And that confronts me with the need to decide whether I'm ready to see these false positives across source code or I have to disable this inspection altogether and endanger me having indeed several transitions into native code where I've could avoid that by caching property value.
So... I think it would be really great if this warning would be shown only for property accesses where in fact happens transition into native code
See: https://github.com/JetBrains/resharper-unity/wiki/Avoid-multiple-unnecessary-property-accesses
The text was updated successfully, but these errors were encountered:
Example of false positive:
When I looked into decompiled code I saw that it just returns private member so it brings one indirection level (which can be optimized by compiler). I consider this is quite non-essential microoptimization. But introducing local variable for a lot of simple cases readability can easily be reduced (not always, of course) so there is a negative impact on this fix as well. And that confronts me with the need to decide whether I'm ready to see these false positives across source code or I have to disable this inspection altogether and endanger me having indeed several transitions into native code where I've could avoid that by caching property value.
So... I think it would be really great if this warning would be shown only for property accesses where in fact happens transition into native code
See:
https://github.com/JetBrains/resharper-unity/wiki/Avoid-multiple-unnecessary-property-accesses
The text was updated successfully, but these errors were encountered: