Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve builtin packages to local package cache #2122

Closed
citizenmatt opened this issue Jul 15, 2021 · 1 comment
Closed

Resolve builtin packages to local package cache #2122

citizenmatt opened this issue Jul 15, 2021 · 1 comment
Assignees

Comments

@citizenmatt
Copy link
Member

It looks like Unity copies "modules"/builtin packages to the local package cache. Rider resolves these packages to the builtin packages folder in the application folder. It might be better to resolve to the package cache. If the packages are compiled by Unity, rather than using precompiled DLLs in the app distribution, then we should resolve the package manager to the files/folders used to generate the reference assemblies. This will reflect any changes made by the API updater (unlikely - they've been copied from the app distribution) and will match up files with PDBs, meaning we can set breakpoints. With quick testing, it looks like navigation works better with the cached files, too.

@citizenmatt citizenmatt self-assigned this Jul 15, 2021
@citizenmatt citizenmatt added this to the Rider 2021.2.1 milestone Jul 15, 2021
@citizenmatt
Copy link
Member Author

More detail: builtin packages are copied to Library/PackageCache and compiled from here (with the result stored in Library/ScriptAssemblies). This happens in Unity 2020.3, and has been back ported to 2019.4. If we open files stored in the app distribution, breakpoints don't resolve because the PDBs point to the files in Library/PackageCache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant