Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't detect Rider 2023.3.3 installed via JetBrains Toolbox 2.1.3 (Linux) #2431

Closed
Schroedingers-Cat opened this issue Feb 6, 2024 · 9 comments

Comments

@Schroedingers-Cat
Copy link

The naming scheme of .desktop files generated by JetBrains Toolbox v2.1.3.18901 has changed recently when installing Rider 2023.3 and other IDEs causing this package to fail detecting Rider installations on Linux. While the files used to be called like jetbrains-rider.desktop, they're now being called jetbrains-rider-c5e460cd-9963-409d-9a9a-0ee2b31cffb8.desktop. This is likely to support installing multiple versions of the same IDE.

Currently, this repo's code on Linux seems to look for a file called jetbrains-rider.desktop in the user's collection directory of desktop files ~/.local/share/applications: https://github.com/JetBrains/resharper-unity/blob/net233/unity/PathLocator/RiderPathLocator.cs#L80

At least, it's how Unity 2021/2022.3 is behaving on my Manjaro Gnome45.3/KDE5.27 systems. This causes Rider installed through JetBrains Toolbox not to be detected by Unity in the Preferences->External Tools window.

The current workaround is to manually rename the file jetbrains-rider-some-hash.desktop to jetbrains-rider.desktop. It would be nice if this package could also support the latest naming scheme from the JetBrains Toolbox app.

@van800
Copy link
Contributor

van800 commented Feb 7, 2024

Please add, where toolbox is in your system and where is Rider. Thanks!

@Schroedingers-Cat
Copy link
Author

Toolbox is at /home/shared/jetbrains-toolbox and Rider is at /home/shared/jetbrains-toolbox/rider. Toolbox shell scripts are at ~/.local/share/JetBrains/Toolbox/scripts.

@van800
Copy link
Contributor

van800 commented Feb 13, 2024

I think, I have a fix for this problem.
But just to be sure, could you please share
$HOME/.local/share/JetBrains/Toolbox/state.json and .settings.json?
Thank you!

@Schroedingers-Cat
Copy link
Author

That sounds great! Here are the requested files:
state.json
.settings.json

@van800
Copy link
Contributor

van800 commented Feb 14, 2024

Thanks! Looks like exactly the problem, which I have fixed.

Currently fixed in the Rider package in branch, currently available on the github mirror.

To try it, you may update one line in the manifest.json, substitute
"com.unity.ide.rider": "3.0.27",
by
"com.unity.ide.rider": "https://github.com/van800/com.unity.ide.rider.git?path=/Packages/com.unity.ide.rider#3.0.28",

@van800 van800 closed this as completed Feb 14, 2024
mfilippov pushed a commit that referenced this issue Feb 18, 2024
GitOrigin-RevId: ff0092f28c01ba6c38512b804cef9975f20a71c1
@Schroedingers-Cat
Copy link
Author

I can confirm that the problem is fixed with the package link you provided, thanks a lot!

Any idea when this version will be officially released?

@van800
Copy link
Contributor

van800 commented Feb 19, 2024

Rough estimation would be 1-2 weeks.

Needle-Mirror-Bot pushed a commit to needle-mirror/com.unity.ide.rider that referenced this issue Feb 28, 2024
## [3.0.28] - 2024-02-20

- fix RIDER-103933 "PlayerSettings.suppressCommonWarnings" is not supported in Unity 2019.4.40f
- fix JetBrains/resharper-unity#2431 and [RIDER-104221](https://youtrack.jetbrains.com/issue/RIDER-104221)
@van800
Copy link
Contributor

van800 commented Feb 28, 2024

Rider package 3.0.28 with a fix was released.

@Schroedingers-Cat
Copy link
Author

Confirming that updating to that package version fixes the issue. Thank you so much!

van800 added a commit to van800/com.unity.ide.rider that referenced this issue Mar 5, 2024
…der/pull/215

- fix RIDER-103933 "PlayerSettings.suppressCommonWarnings" is not supported in Unity 2019.4.40f
- fix JetBrains/resharper-unity#2431 and [RIDER-104221](https://youtrack.jetbrains.com/issue/RIDER-104221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants