Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unity plugin from Rider 2018.2.1 doesn't set LangVersion correctly #751

Closed
renattou opened this issue Aug 30, 2018 · 8 comments
Closed

Unity plugin from Rider 2018.2.1 doesn't set LangVersion correctly #751

renattou opened this issue Aug 30, 2018 · 8 comments
Assignees

Comments

@renattou
Copy link

After updating to Rider 2018.2.1 (plugin version 2018.2.0.78), the Unity plugin sets the LangVersion tag as empty. Like this: <LangVersion></LangVersion>.
This causes Rider to suggest C#6 features even though we use C#4.
Downgrading to 2018.1.4 (plugin version 2018.1.0.133) fix the problem, setting it as <LangVersion>4</LangVersion>.

@van800 van800 self-assigned this Aug 30, 2018
@van800 van800 added this to the Rider 2018.2.2 milestone Aug 30, 2018
@van800
Copy link
Contributor

van800 commented Aug 30, 2018

@renattou I can't reproduce it.
What is your Unity version and OS?

Make sure you have "Override LangVersion" unchecked
image

Please set LoggingLevel to Verbose and call Assets->Sync C# Project, logs will appear in %TEMP%\Unity3dRider or $TMDDIR\Unity3dRider depending on the OS. Thanks!

@renattou
Copy link
Author

@van800 I'm using using Unity 5.6.5p3 on macOS 10.13.6.

Using Rider 2018.1.4: 2018.1.4.log
Using Rider 2018.2.1: 2018.2.1.log

I checked the override option, but it was already unchecked.

@renattou
Copy link
Author

I found this comment https://gist.github.com/van800/875ce55eaf88d65b105d010d7b38a8d4#gistcomment-2689159
which could be associated with this issue.

@van800
Copy link
Contributor

van800 commented Aug 31, 2018

@renattou Does it work if you check "Override LangVersion" and specifically change it to 4?

@van800
Copy link
Contributor

van800 commented Aug 31, 2018

I was able to reproduce the problem. Thank you.

@van800
Copy link
Contributor

van800 commented Aug 31, 2018

Until build with fix is out, you may use "Override LangVersion" setting.

@renattou
Copy link
Author

@van800 glad to hear you could reproduce it! I'm using the override setting for now and it's working. Thanks!

van800 added a commit that referenced this issue Aug 31, 2018
* update LangVersion in case we were unable to parse existing one #751
* handle "default" value of LangVersion
@van800
Copy link
Contributor

van800 commented Sep 3, 2018

Fix is available in the nightly builds, which are accessible via https://www.jetbrains.com/toolbox/app/

@van800 van800 closed this as completed Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants