Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception for file: and git based packages #1099

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Fix exception for file: and git based packages #1099

merged 3 commits into from
Mar 24, 2019

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Mar 24, 2019 •
edited
Loading

This PR will:

  • Correctly handle local file: and git based packages in Unity Explorer
  • Unresolved packages will no longer crash the Unity Explorer, but be displayed as unresolved nodes
  • Simplify sorting nodes in the Unity Explorer tree

Fixes #1095, fixes RIDER-25971

@citizenmatt citizenmatt added bug refactor Internal tasks. Refactor, adding tests, etc. labels Mar 24, 2019
@citizenmatt citizenmatt added this to the Rider 2019.1 milestone Mar 24, 2019
@citizenmatt citizenmatt self-assigned this Mar 24, 2019
@citizenmatt citizenmatt requested a review from van800 March 24, 2019 06:41
van800
van800 approved these changes Mar 24, 2019
View reviewed changes
Copy link
Contributor

@van800 van800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

rider/src/main/kotlin/com/jetbrains/rider/plugins/unity/explorer/AssetsRoot.kt Show resolved Hide resolved
@citizenmatt citizenmatt merged commit cbf5c04 into 191 Mar 24, 2019
@citizenmatt citizenmatt deleted the bugfix/git-packages branch March 24, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@van800 van800 van800 approved these changes

Assignees

@citizenmatt citizenmatt

Labels
bug refactor Internal tasks. Refactor, adding tests, etc.
Projects
None yet
Milestone
Rider 2019.1
Development

Successfully merging this pull request may close these issues.

Unity Explorer disappeared
2 participants
@citizenmatt @van800