fix RIDER-26102, RIDER-26109, RIDER-26103 #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix RIDER-26109
van800
changed the title
van800
changed the title
citizenmatt
reviewed
Mar 28, 2019
| @@ -40,7 +40,7 @@ public static bool HasUnityReference([NotNull] this ISolution solution) | |||
| public static bool IsUnityProject([CanBeNull] this IProject project) | |||
| { | |||
| // Only VSTU adds the Unity project flavour. Unity + Rider don't, so we have to look at references | |||
| return project != null && (project.HasFlavour<UnityProjectFlavor>() || ReferencesUnity(project)); | |||
| return project != null && (project.HasFlavour<UnityProjectFlavor>() || project.IsValid() && ReferencesUnity(project)); | |||
There was a problem hiding this comment.
Why would project be invalid here?
There was a problem hiding this comment.
missing/incompatible msbuild?
There was a problem hiding this comment.
Oh, would we still have a project in that case?
There was a problem hiding this comment.
I don't know, I can't reproduce it for real
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.