Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all package folders to index #1120

Merged
merged 10 commits into from
Apr 4, 2019
Merged

Add all package folders to index #1120

merged 10 commits into from
Apr 4, 2019

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Apr 3, 2019

This PR changes what non-project files are indexed:

  • All packages are indexed. This includes the contents of the Packages folder, as well as any cached, read only/referenced packages, and any file: or git based packages.
  • Removes non-project root folders from the index. This can have a huge impact on the file index if e.g. a backup copy of the Library folder is made to avoid a lengthy reimport all, or a player project is built into the root folder of the Unity project
  • It also fixes a few edge cases where the Packages Explorer nodes would resolve incorrectly (e.g. editing the Packages/manifest.json file to add a package that hasn't yet been resolved by Unity).

Note that the contents of these folders will only show up when the "Include non-solution items" checkbox is selected in Find in Files.

The code will keep the index up to date as packages are added/removed/updated, and root folders are added/removed and when the project model is reloaded (meaning packages are correctly resolved).

This fixes RIDER-25340 as well as reducing the indexing time for projects that include extra folders at the root.

@citizenmatt citizenmatt added this to the Rider 2019.1 milestone Apr 3, 2019
@citizenmatt citizenmatt self-assigned this Apr 3, 2019
@citizenmatt citizenmatt requested a review from xtmq April 3, 2019 20:05
@citizenmatt citizenmatt merged commit e2eeea1 into 191 Apr 4, 2019
@citizenmatt citizenmatt deleted the feature/file-index branch April 4, 2019 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants