Fix failure to rename scriptable objects #1196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rename process tries to validate the rename worked, by resolving the new reference against the newly renamed declared element. For script components, resolve takes the name from the file name, which hasn't yet been renamed, meaning that the rename of the reference also failed.
This PR changes how the reference handles rename. It will now create a new reference and pass in the new name of the class being renamed. During resolve, if this expected resolved name is available, it will be used to match, otherwise, the filename is used.