Show autosave configure notifcation after first typing in play mode #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irst typing in playmode
van800
reviewed
Jul 29, 2019
| MainThreadDispatcher.Instance.Queue(() => | ||
| { | ||
|
|
||
| var tab = UnityUtils.UnityVersion >= new Version(2018, 2) ? "_General" : "Rider"; |
There was a problem hiding this comment.
adding try-catch-log may be good idea here.
kskrygan
reviewed
Jul 29, 2019
| if (!lifetimeDefinition.isAlive) | ||
| return | ||
|
|
||
| val generalSettings = GeneralSettings.getInstance() |
There was a problem hiding this comment.
let's move GeneralSettings.getInstance out of this scope, so it won't be calculated for every doc change
There was a problem hiding this comment.
Ooops. Thanks!
| val eventMulticaster = EditorFactory.getInstance().eventMulticaster | ||
| val documentListener: DocumentListener = object : DocumentListener { | ||
| override fun documentChanged(event: DocumentEvent) { | ||
| if (unityHost.model.editorState.valueOrDefault(EditorState.Disconnected) != EditorState.ConnectedPlay) |
There was a problem hiding this comment.
if this works for o(1) then it's fine.
There was a problem hiding this comment.
AFAIK, our model properties cache value
| if (!unityHost.model.scriptCompilationDuringPlay.hasValue) | ||
| return | ||
|
|
||
| if (unityHost.model.scriptCompilationDuringPlay.valueOrThrow != ScriptCompilationDuringPlay.RecompileAndContinuePlaying) |
There was a problem hiding this comment.
why valueOrThrow? Isn't throwing assertions here too aggressive?
| lifetimeDefinition.terminate() | ||
| } | ||
|
|
||
| panel.createActionLabel("Don't show again") { |
There was a problem hiding this comment.
"Do not show again"
Please avoid using "don't", "ain't" and other reductions in UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.