Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Attach to Unity Process" dialog #1730

Merged
merged 14 commits into from
Jul 2, 2020
Merged

Conversation

citizenmatt
Copy link
Member

This PR improves the UX of the Attach to Unity Process dialog, and fixes a few bugs in player discovery

  • Editors and players are now grouped by project, when available (grouped by "Unknown project" when not)
  • Editor helper processes are shown as child nodes in a tree view
  • Within groups, processes are listed in order of importance - editors, then editor helpers, local/standalone players, remote players
  • Local processes, such as editors and editor helpers are refreshed once a second, so new processes are added/removed while the dialog is open
  • Local process discovery now only checks if a process is called "Unity", rather than trying to match heuristics. This mimics what Unity do in their own debugger plugins for other IDEs
  • Player discovery is rewritten and improved:
    • Previously, polling would read one broadcast message from a socket and sleep, while more messages are being sent, creating a backlog that is never properly processed. This could prevent all players being correctly listed. Now we read all available messages
    • Previously, polling was handled with blocking and timeouts. This has been rewritten to use select style semantics - only do something if the socket has data
  • Unity specific run configurations are now only available in Unity projects, and are dumb aware

Screenshot 2020-06-25 at 11 39 16 am

@citizenmatt citizenmatt added this to the Rider 2020.2 milestone Jul 2, 2020
@citizenmatt citizenmatt self-assigned this Jul 2, 2020
@citizenmatt citizenmatt requested a review from van800 July 2, 2020 12:44
@citizenmatt citizenmatt merged commit 0654f83 into net202 Jul 2, 2020
@citizenmatt citizenmatt deleted the feature/debug-dialog branch July 2, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants