Support macroses which comes from directives for ShaderLab #1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizenmatt
requested changes
Aug 27, 2020
| } | ||
|
|
||
| if (pragmaType.Equals("target")) | ||
| shaderTarget = firstValue.Replace(".", ""); |
There was a problem hiding this comment.
It's not obvious that shaderTarget is a shader version. Perhaps replace the "25", "40" and "50" magic strings with constants that explain the name? Also, is it legal to specify both target and geometry or hull? What should the target version be then?
There was a problem hiding this comment.
#pragma target 3.0
#pragma geometry geom
#if SHADER_TARGET == 40
#error GEOMETRY
#endif
I got "GEOMETRY" error in Unity when compiling that shader. That means that geometry is preferred by Unity thatn target directive
There was a problem hiding this comment.
Target is maximum version then, I replaced literals by constants with names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could not provide full support multi_compile/shader_target directives due to complexity problem. That PR analysis directives and extract first combination of defines, also that PR covers target directive and some built-in multi_compile directives.