Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate protocol when Rider is closed #1881

Merged
merged 8 commits into from
Oct 9, 2020

Conversation

krasnotsvetov
Copy link
Collaborator

No description provided.

…col leads to different errors, e.g deserialization errors, not-working scope interning and so on
…y mode filter in rider unity log, we should check that previous app domain was in play mode too and do not change last play time
@@ -8,6 +8,11 @@ internal class RiderScriptableSingleton: ScriptObjectSingleton<RiderScriptableSi
{
[SerializeField]
private bool myCsprojProcessedOnce;

[SerializeField]
private bool myLastPlayModeEnabled = false;
Copy link
Contributor

@van800 van800 Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I recall RiderScriptableSingleton would not work at all with Unity 2019.2+, need to check.

@krasnotsvetov krasnotsvetov merged commit a9c4ea0 into net203 Oct 9, 2020
@citizenmatt citizenmatt deleted the net203-vk-protocol-improvments branch December 16, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants